Skip to content

chore(#4165): rename llamastack to ogx across boost workspace - #4167

Merged
gabemontero merged 3 commits into
mainfrom
agent/4165-rename-llamastack-to-ogx
Aug 4, 2026
Merged

chore(#4165): rename llamastack to ogx across boost workspace#4167
gabemontero merged 3 commits into
mainfrom
agent/4165-rename-llamastack-to-ogx

Conversation

@fullsend-ai-coder

Copy link
Copy Markdown
Contributor

The upstream llamastack project has been renamed to ogx. This commit renames all references across the boost workspace to reflect the new project name, including:

  • Plugin directories: boost-backend-module-llamastack → ogx,
    llamastack-entity-provider → ogx-entity-provider
  • npm package names under @Red-Hat-Developer-Hub scope
  • TypeScript identifiers: module exports, class names, interfaces,
    config paths, cache key prefixes, provider IDs, and entity names
  • Backend registration imports in packages/backend
  • app-config.yaml provider config key (boost.providers.ogx)
  • Dynamic plugin reference YAML files
  • AGENTS.md and README.md package tables
  • Test expectations for renamed provider IDs, cache keys, and
    entity name prefixes

CHANGELOG.md files and openspec/specification docs are preserved as historical records and not renamed.


Closes #4165

Post-script verification

  • Branch is not main/master (agent/4165-rename-llamastack-to-ogx)
  • Secret scan passed (gitleaks — 234bc786f89bca0dc16dd20f9568eeb0931f38e2..HEAD)
  • Pre-commit hooks passed (authoritative run on runner)
  • Tests ran inside sandbox

The upstream llamastack project has been renamed to ogx. This commit
renames all references across the boost workspace to reflect the new
project name, including:

- Plugin directories: boost-backend-module-llamastack → ogx,
  llamastack-entity-provider → ogx-entity-provider
- npm package names under @Red-Hat-Developer-Hub scope
- TypeScript identifiers: module exports, class names, interfaces,
  config paths, cache key prefixes, provider IDs, and entity names
- Backend registration imports in packages/backend
- app-config.yaml provider config key (boost.providers.ogx)
- Dynamic plugin reference YAML files
- AGENTS.md and README.md package tables
- Test expectations for renamed provider IDs, cache keys, and
  entity name prefixes

CHANGELOG.md files and openspec/specification docs are preserved
as historical records and not renamed.

Closes #4165
@fullsend-ai-coder fullsend-ai-coder Bot added the ready-for-review Agent PR ready for human review label Aug 4, 2026
@rhdh-gh-app

rhdh-gh-app Bot commented Aug 4, 2026

Copy link
Copy Markdown

Important

This PR includes changes that affect public-facing API. Please ensure you are adding/updating documentation for new features or behavior.

Changed Packages

Package Name Package Path Changeset Bump Current Version
backend workspaces/boost/packages/backend none v0.0.0
@red-hat-developer-hub/backstage-plugin-boost-backend-module-ogx workspaces/boost/plugins/boost-backend-module-ogx minor v0.1.2
@red-hat-developer-hub/backstage-plugin-boost-backend workspaces/boost/plugins/boost-backend patch v0.1.3
@red-hat-developer-hub/backstage-plugin-boost-common workspaces/boost/plugins/boost-common patch v0.1.3
@red-hat-developer-hub/backstage-plugin-ogx-entity-provider workspaces/boost/plugins/ogx-entity-provider minor v0.1.1

@codecov

codecov Bot commented Aug 4, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.96%. Comparing base (234bc78) to head (0bd187d).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4167   +/-   ##
=======================================
  Coverage   54.96%   54.96%           
=======================================
  Files        2413     2413           
  Lines       96074    96074           
  Branches    26898    26898           
=======================================
  Hits        52809    52809           
  Misses      41770    41770           
  Partials     1495     1495           
Flag Coverage Δ *Carryforward flag
adoption-insights 84.55% <ø> (ø) Carriedforward from 66f2e8d
ai-integrations 69.76% <ø> (ø) Carriedforward from 66f2e8d
app-defaults 69.79% <ø> (ø) Carriedforward from 66f2e8d
augment 46.67% <ø> (ø) Carriedforward from 66f2e8d
boost 76.77% <66.66%> (ø)
bulk-import 72.56% <ø> (ø) Carriedforward from 66f2e8d
cost-management 13.55% <ø> (ø) Carriedforward from 66f2e8d
dcm 60.72% <ø> (ø) Carriedforward from 66f2e8d
extensions 56.59% <ø> (ø) Carriedforward from 66f2e8d
global-floating-action-button 71.18% <ø> (ø) Carriedforward from 66f2e8d
global-header 66.50% <ø> (ø) Carriedforward from 66f2e8d
homepage 47.50% <ø> (ø) Carriedforward from 66f2e8d
install-dynamic-plugins 59.95% <ø> (ø) Carriedforward from 66f2e8d
intelligent-assistant 74.61% <ø> (ø) Carriedforward from 66f2e8d
konflux 91.98% <ø> (ø) Carriedforward from 66f2e8d
lightspeed 69.02% <ø> (ø) Carriedforward from 66f2e8d
mcp-integrations 83.40% <ø> (ø) Carriedforward from 66f2e8d
orchestrator 66.87% <ø> (ø) Carriedforward from 66f2e8d
quickstart 63.74% <ø> (ø) Carriedforward from 66f2e8d
sandbox 79.56% <ø> (ø) Carriedforward from 66f2e8d
scorecard 85.98% <ø> (ø) Carriedforward from 66f2e8d
theme 88.77% <ø> (ø) Carriedforward from 66f2e8d
translations 5.12% <ø> (ø) Carriedforward from 66f2e8d
x2a 12.40% <ø> (ø) Carriedforward from 66f2e8d

*This pull request uses carry forward flags. Click here to find out more.


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 234bc78...0bd187d. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gabemontero

Copy link
Copy Markdown
Contributor

/fs-fix add changesets via the process articulated in https://github.com/backstage/backstage/blob/master/CONTRIBUTING.md#creating-changesets for all affected packages and plugins; add a yarn directive into package.json if needed that replicates what is done in other workspaces

@fullsend-ai-coder

fullsend-ai-coder Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor Author

🤖 Finished Fix · ✅ Success · Started 4:09 PM UTC · Completed 4:16 PM UTC
Commit: 928a64d · View workflow run →

Add changeset documenting the package rename from llamastack to ogx
for all affected boost workspace packages: boost-backend-module-ogx
(minor), ogx-entity-provider (minor), boost-backend (patch), and
boost-common (patch).

Addresses review feedback on #4167
@fullsend-ai-coder

Copy link
Copy Markdown
Contributor Author

🔧 Fix agent — iteration 1 (human-triggered)

Added changeset for the llamastack-to-ogx rename covering all 4 affected public packages (2 minor for renamed packages, 2 patch for internal reference updates). No yarn directive needed — boost already has @changesets/cli configured identically to other workspaces.

Fixed (1):

  1. add changesets for all affected packages and plugins: Created changeset file at workspaces/boost/.changeset/rename-llamastack-to-ogx.md covering all 4 affected non-private packages: boost-backend-module-ogx (minor - package renamed), ogx-entity-provider (minor - package renamed), boost-backend (patch - internal string changes), and boost-common (patch - JSDoc/test comment changes). The backend package is private and does not need a changeset.

Disagreed (1):

  1. add a yarn directive into package.json if needed: No additional yarn directive is needed. The boost workspace already has @changesets/cli (^2.27.1) in devDependencies and a .changeset/config.json. No other workspace in the repo has a dedicated changeset script in package.json — they all rely on @changesets/cli providing the changeset binary, making yarn changeset work out of the box. The boost workspace already follows this same pattern.

Tests: passed

Updated by fullsend fix agent

@gabemontero

Copy link
Copy Markdown
Contributor

/fs-review

@fullsend-ai-review

fullsend-ai-review Bot commented Aug 4, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 4:24 PM UTC · Completed 4:42 PM UTC
Commit: 66f2e8d · View workflow run →

@fullsend-ai-review

Copy link
Copy Markdown

Review

Findings

High

  • [stale-reference] workspaces/boost/scripts/load-secrets.sh:61 — The load-secrets.sh script discovers and exports BOOST_LLAMA_STACK_URL, but app-config.yaml was changed to read BOOST_OGX_URL. After merge, developers sourcing this script will have the URL exported under the wrong env var name, and the config will silently fall back to http://localhost:8321. The function name _discover_llama_stack_route and warning messages also reference the old name.
    Remediation: Rename BOOST_LLAMA_STACK_URLBOOST_OGX_URL and _discover_llama_stack_route_discover_ogx_route throughout scripts/load-secrets.sh.

Medium

  • [npm-package-rename] workspaces/boost/.changeset/rename-llamastack-to-ogx.md — Two previously published npm packages (@red-hat-developer-hub/backstage-plugin-boost-backend-module-llamastack v0.1.2, @red-hat-developer-hub/backstage-plugin-llamastack-entity-provider v0.1.1) are renamed without deprecation of the old package names. Downstream consumers depending on the old names will see resolution failures. The changeset documents the rename, and v0.x packages allow breaking changes under semver conventions, but npm deprecate on the old names after publishing would ease the transition.

Low

  • [grammar-error] workspaces/boost/dynamic-plugins-filesystem-reference.yaml:39 — Comment reads "connects to a OGX Responses API endpoint" — should be "an OGX" (vowel sound).
  • [grammar-error] workspaces/boost/dynamic-plugins-image-reference.yaml:38 — Same grammar issue: "a OGX" → "an OGX".
  • [stale-reference] workspaces/boost/staged-issues.md — 9 references to old naming (llamastack, Llama Stack, boost-backend-module-llamastack) remain across lines 272, 287, 292, 346, 355, 448. This planning document is not explicitly exempted as a historical record in the PR description (unlike CHANGELOG.md and openspec/specification docs).
  • [config-path-breaking-change] workspaces/boost/plugins/boost-backend-module-ogx/src/provider/ResponsesApiProviderFactory.ts — Config paths boost.providers.llamastackboost.providers.ogx and boost.entityProviders.llamastackboost.entityProviders.ogx changed without a migration shim. Expected for v0.x rename; document in release notes.
  • [catalog-entity-identity-change] workspaces/boost/plugins/ogx-entity-provider/src/providers/OgxModelEntityProvider.ts — Entity name prefixes change from llamastack-* to ogx-*; old entities become catalog orphans. Expected for v0.x rename; document in release notes.
  • [cache-key-migration] workspaces/boost/plugins/boost-backend-module-ogx/src/provider/SessionMap.ts — Cache key prefixes change from llamastack: to ogx:. Existing cached data (sessions, client state, MCP auth tokens) becomes inaccessible. Impact is transient — all caches have TTLs ≤ 24h.
  • [dynamic-plugin-path-change] workspaces/boost/dynamic-plugins-filesystem-reference.yaml:39 — Dynamic plugin reference paths changed. Deployed RHDH instances must update their dynamic-plugins.yaml.

Labels: All changes are within the boost workspace (workspaces/boost/)


Next steps:

  • /fs-fix — agent addresses review findings automatically
  • /fs-fix <your instruction> — agent fixes with your specific guidance
  • Push commits directly — review re-runs automatically on push
  • /fs-fix-stop — disable automatic fix runs for this PR

@fullsend-ai-review fullsend-ai-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the review comment for full details.


Note: The following inline comments could not be posted on the diff (GitHub returned 422) and are included here instead:

  • workspaces/boost/.changeset/rename-llamastack-to-ogx.md:1: [medium] npm-package-rename

Two previously published npm packages are renamed without deprecation of the old package names. Downstream consumers depending on the old names will see resolution failures. The changeset documents the rename, and v0.x packages allow breaking changes under semver conventions, but npm deprecate on the old names after publishing would ease the transition.

Suggested fix: After publishing, run npm deprecate on the old package names pointing to the new names.

  • workspaces/boost/dynamic-plugins-filesystem-reference.yaml:39: [low] grammar-error

Comment reads 'connects to a OGX Responses API endpoint' - should use 'an OGX' since OGX starts with a vowel sound.

Suggested fix: Change 'a OGX' to 'an OGX'.

  • workspaces/boost/dynamic-plugins-image-reference.yaml:38: [low] grammar-error

Same grammar issue: 'connects to a OGX' should be 'an OGX'.

Suggested fix: Change 'a OGX' to 'an OGX'.

  • workspaces/boost/plugins/boost-backend-module-ogx/src/provider/ResponsesApiProviderFactory.ts (file-level): Line 107 · [low] config-path-breaking-change

Config paths boost.providers.llamastack and boost.entityProviders.llamastack renamed to boost.providers.ogx and boost.entityProviders.ogx. Existing deployments will need config updates. Expected for v0.x rename.

  • workspaces/boost/plugins/ogx-entity-provider/src/providers/OgxModelEntityProvider.ts:40: [low] catalog-entity-identity-change

Entity name prefixes change from llamastack-model-/llamastack-agent- to ogx-model-/ogx-agent-. Old entities become catalog orphans. Expected for v0.x rename.

  • workspaces/boost/plugins/boost-backend-module-ogx/src/provider/SessionMap.ts:57: [low] cache-key-migration

Cache key prefixes change from llamastack: to ogx:. Existing cached data becomes inaccessible. Impact is transient - all caches have TTLs <= 24h.

  • workspaces/boost/dynamic-plugins-filesystem-reference.yaml:39: [low] dynamic-plugin-path-change

Dynamic plugin reference paths changed from llamastack to ogx. Deployed RHDH instances referencing the old path will fail to load the plugin.

@fullsend-ai-review fullsend-ai-review Bot added the workspace/boost Boost workspace (Backstage AI plugin) label Aug 4, 2026
@gabemontero

Copy link
Copy Markdown
Contributor

/fs-fix Rename BOOST_LLAMA_STACK_URL to BOOST_OGX_URL and _discover_llama_stack_route to _discover_ogx_route throughout scripts/load-secrets.sh

@fullsend-ai-coder

fullsend-ai-coder Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor Author

🤖 Finished Fix · ✅ Success · Started 5:15 PM UTC · Completed 5:21 PM UTC
Commit: 66f2e8d · View workflow run →

@gabemontero

Copy link
Copy Markdown
Contributor

From review #4167 (comment) only addressing

High
[stale-reference] workspaces/boost/scripts/load-secrets.sh:61 — The load-secrets.sh script discovers and exports BOOST_LLAMA_STACK_URL, but app-config.yaml was changed to read BOOST_OGX_URL. After merge, developers sourcing this script will have the URL exported under the wrong env var name, and the config will silently fall back to http://localhost:8321. The function name _discover_llama_stack_route and warning messages also reference the old name.
Remediation: Rename BOOST_LLAMA_STACK_URL → BOOST_OGX_URL and _discover_llama_stack_route → _discover_ogx_route throughout scripts/load-secrets.sh.

wrt to the npm deprecate all npm manipulation is done from CI ... we don't have authority to do that from the command line like the review comment suggests

not wasting tokens on any of the low's ... in particular I want staged-issues.md to only reflect the state of things when those github issues were processed ; don't need to updates as the workspace progresses

Rename BOOST_LLAMA_STACK_URL to BOOST_OGX_URL and
_discover_llama_stack_route to _discover_ogx_route throughout
scripts/load-secrets.sh to match the llamastack-to-ogx rename.

Addresses review feedback on #4167
@fullsend-ai-coder

Copy link
Copy Markdown
Contributor Author

🔧 Fix agent — iteration 2 (human-triggered)

Renamed BOOST_LLAMA_STACK_URL to BOOST_OGX_URL and _discover_llama_stack_route to _discover_ogx_route throughout scripts/load-secrets.sh per human instruction, completing the llamastack-to-ogx rename in this file.

Fixed (2):

  1. Rename BOOST_LLAMA_STACK_URL to BOOST_OGX_URL in load-secrets.sh (workspaces/boost/scripts/load-secrets.sh): Renamed all occurrences of BOOST_LLAMA_STACK_URL to BOOST_OGX_URL (variable assignment, export, conditional check, and echo output)
  2. Rename _discover_llama_stack_route to _discover_ogx_route in load-secrets.sh (workspaces/boost/scripts/load-secrets.sh): Renamed function _discover_llama_stack_route to _discover_ogx_route (function definition, invocation, and unset -f call), and updated related comments and warning messages to reference OGX instead of Llama Stack

Tests: passed

Updated by fullsend fix agent

@sonarqubecloud

sonarqubecloud Bot commented Aug 4, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
6.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@gabemontero

Copy link
Copy Markdown
Contributor

I checked out this PR's branch and the llamastack entity provider works as expected

image

evidence of the rename in the backend logs:

2026-08-04T18:20:33.133Z catalog info Refreshing model entities from OGX at https://llamastack-llamastack.apps.gmontero420.rhdh-pai.devfile-ci.com target="ogx-model-entity-provider"
2026-08-04T18:20:33.349Z catalog info Fetched 367 model entities from OGX target="ogx-model-entity-provider"
2026-08-04T18:21:33.359Z catalog info Refreshing model entities from OGX at https://llamastack-llamastack.apps.gmontero420.rhdh-pai.devfile-ci.com target="ogx-model-entity-provider"
2026-08-04T18:21:33.581Z catalog info Fetched 367 model entities from OGX target="ogx-model-entity-provider"

@gabemontero
gabemontero merged commit 54345de into main Aug 4, 2026
36 of 37 checks passed
@fullsend-ai-retro

fullsend-ai-retro Bot commented Aug 4, 2026

Copy link
Copy Markdown

🤖 Finished Retro · ✅ Success · Started 6:24 PM UTC · Completed 6:44 PM UTC
Commit: 0bd187d · View workflow run →

@fullsend-ai-retro

Copy link
Copy Markdown

Retro: PR #4167 — rename llamastack → ogx across boost workspace

Timeline

  1. 14:57 UTC — gabemontero opens issue #4165 requesting rename. Scope lists "typescript files, markdowns, or app-config.yaml examples."
  2. 14:58–15:03 UTC — Triage agent runs successfully (run 30921748967), identifies affected packages and recommends approach.
  3. 15:38–16:03 UTC — Code agent runs (run 30925207455), produces commit 928a64d renaming 46 files. Misses scripts/load-secrets.sh and changeset file.
  4. ~16:08 UTC — Human triggers /fs-fix to add changesets. Fix agent adds changeset (commit 66f2e8d).
  5. ~16:23 UTC — Human triggers /fs-review. Review agent submits CHANGES_REQUESTED at 16:42 UTC with a HIGH finding: load-secrets.sh still exports BOOST_LLAMA_STACK_URL but app-config.yaml now reads BOOST_OGX_URL.
  6. 16:42 UTC — Auto-dispatch of fix agent after review fails (bot name mismatch in routing + LoadWithBase harness error).
  7. ~17:14 UTC — Human manually triggers /fs-fix with specific instructions for load-secrets.sh. Fix agent completes (commit 0bd187d).
  8. 18:22 UTC — gabemontero approves after manual verification against a live OGX endpoint. PR merged at 18:23 UTC.

What went well

  • Review agent caught a real bug. The HIGH finding about load-secrets.sh env var mismatch was 100% accurate and would have caused a silent runtime fallback to http://localhost:8321. Both HIGH findings were fixed before merge.
  • Triage quality was good. The triage agent correctly identified all affected packages and recommended a sound approach.
  • Code agent handled a large rename competently. 46 files across TypeScript, config, docs, and tests were correctly renamed in a single commit — the bulk of the work was correct.

What could go better

  • Two fix iterations were needed — one for changesets, one for load-secrets.sh. Both are addressable with better repo-level context.
  • Auto-dispatch was broken. All 4 pull_request_target fullsend.yaml runs failed to route because bot accounts lack collaborator permissions. The pull_request_review run also failed to auto-dispatch fix because the routing logic constructs redhat-developer-review[bot] but the actual reviewer is fullsend-ai-review[bot]. Human had to manually trigger both /fs-review and /fs-fix.
  • Review agent got 422 errors when posting inline comments on the diff, so all findings were included in the review body instead.

Existing issues this retro found evidence for

  • rhdh-plugins#3745 (changeset instructions in agent config): This PR is another instance where the code agent omitted changesets, requiring a /fs-fix iteration. Same pattern as the original issue.
  • rhdh-plugins#4166 (restore review dispatch for bot-authored PRs): This PR confirms the dispatch failure pattern — all pull_request_target runs failed to route because fullsend-ai-coder[bot] has no collaborator permission.
  • fullsend#5446 (LoadWithBase harness errors): The .fullsend/rhdh/harness/code.yaml and fix.yaml both failed to load with base field is set but harness was not loaded with LoadWithBase, confirming this repo is affected.
  • fullsend#5536 (bot-authored PR eligibility): The review→fix auto-handoff failed because the routing logic uses ${ORG_NAME}-review[bot] which doesn't match fullsend-ai-review[bot].
  • rhdh-plugins#4025 (boost AGENTS.md improvements): This PR adds evidence that the boost workspace AGENTS.md is missing structural documentation (scripts/ directory not covered).

Proposals filed

gabemontero pushed a commit that referenced this pull request Aug 4, 2026
Add the scripts/ directory and load-secrets.sh to the workspace
directory tree and add a new "Scripts directory" section that
documents the env-var synchronization requirement between
load-secrets.sh and app-config.yaml. This ensures code agents
discover load-secrets.sh during rename or refactor tasks that
touch config keys under boost.providers.*.

Root cause: PR #4167 renamed llamastack to ogx across 46 files
but missed load-secrets.sh because AGENTS.md did not mention the
scripts/ directory. The review agent caught the desync before
merge, but a /fs-fix round-trip was needed to complete the rename.

Closes #4168

Co-authored-by: fullsend-code <278716306+fullsend-ai-coder[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-review Agent PR ready for human review workspace/boost Boost workspace (Backstage AI plugin)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(boost-backend-module-llamastack,llamastack-entity-provider): rename llamastack to ogx

1 participant